Advertisement
PVS-StudioWarnings

PVS-Studio warning V519 for Source SDK

Nov 27th, 2014
186
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.73 KB | None | 0 0
  1. void CEnvTonemapController::InputSetBloomScaleRange(
  2.   inputdata_t &inputdata )
  3. {
  4.   ....
  5.   m_flCustomBloomScale=bloom_max;
  6.   m_flCustomBloomScale=bloom_min;
  7. }
  8.  
  9. Most likely this is what should be written here: m_flCustomBloomScale=bloom_max; m_flCustomBloomScaleMinimum=bloom_min;
  10.  
  11. This suspicious code was found in Source SDK project by PVS-Studio static code analyzer.
  12. Warning message is:
  13. V519 The 'm_flCustomBloomScale' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 171, 172. Server (HL2) env_tonemap_controller.cpp 172
  14.  
  15. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement