Advertisement
PVS-StudioWarnings

PVS-Studio warning V549 for ReactOS

Nov 21st, 2014
155
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.63 KB | None | 0 0
  1. static void _Stl_loc_combine_names(_Locale_impl* L,
  2.   const char* name1, const char* name2,
  3.   locale::category c)
  4. {
  5.   if ((c & locale::all) == 0 ||
  6.       strcmp(name1, name1) == 0)
  7.   ...
  8. }
  9.  
  10. This is what should have been written here: strcmp(name1, name2)
  11.  
  12. This suspicious code was found in ReactOS project by PVS-Studio static code analyzer.
  13. Warning message is:
  14. V549 The first argument of 'strcmp' function matches it's the second argument. stlport locale.cpp 211
  15.  
  16. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement