Advertisement
PVS-StudioWarnings

PVS-Studio warning V676 for Firebird

Nov 25th, 2014
151
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.63 KB | None | 0 0
  1. THREAD_ENTRY_DECLARE start_and_watch_server(THREAD_ENTRY_PARAM)
  2. {
  3.   ....
  4.   success = CreateProcess(....);
  5.   if (success != TRUE)
  6.     error = GetLastError();
  7.   ....
  8. }
  9.  
  10. #info If the function succeeds, the return value is nonzero.
  11.  
  12. This suspicious code was found in Firebird project by PVS-Studio static code analyzer.
  13. Warning message is:
  14. V676 It is incorrect to compare the variable of BOOL type with TRUE. Correct expression is: 'success == FALSE'. iscguard.cpp 667
  15.  
  16. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement