Advertisement
Not a member of Pastebin yet?
Sign Up,
it unlocks many cool features!
- bool Set_RS_Val()
- {
- ....
- int appliedSize;
- ....
- if((appliedSize == TEXT('b') && appliedSize == TEXT('s') &&
- (rs_param < -128 || rs_param > 127)) ||
- (appliedSize == TEXT('b') && appliedSize != TEXT('s') &&
- (rs_param < 0 || rs_param > 255)) ||
- (appliedSize == TEXT('w') && appliedSize == TEXT('s') &&
- (rs_param < -32768 || rs_param > 32767)) ||
- (appliedSize == TEXT('w') && appliedSize != TEXT('s') &&
- (rs_param < 0 || rs_param > 65535)))
- return false;
- ....
- }
- This suspicious code was found in Snes9x project by PVS-Studio static code analyzer.
- Warning message is:
- V547 Expression is always false. Probably the '||' operator should be used here. ram_search.cpp 921
- PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement