Advertisement
PVS-StudioWarnings

PVS-Studio warning V668 for TinyXML

Nov 24th, 2014
148
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.87 KB | None | 0 0
  1. void TiXmlElement::SetAttribute(
  2.   const char * cname, const char * cvalue )
  3. {
  4.   ....
  5.   TiXmlAttribute* attrib = new TiXmlAttribute( cname, cvalue );
  6.   if ( attrib )
  7.   {
  8.     attributeSet.Add( attrib );
  9.   }
  10.   else
  11.   {
  12.     TiXmlDocument* document = GetDocument();
  13.     if ( document ) document->SetError(
  14.       TIXML_ERROR_OUT_OF_MEMORY, 0, 0, TIXML_ENCODING_UNKNOWN );
  15.   }
  16.   ....
  17. }
  18.  
  19. This suspicious code was found in TinyXML project by PVS-Studio static code analyzer.
  20. Warning message is:
  21. V668 There is no sense in testing the 'attrib' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. oics tinyxml.cpp 735
  22.  
  23. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement