extracthalotagdefs diffs by Smx

--- "/l/Program Files (x86)/Microsoft Games/Halo Custom Edition/progs/extracthalotagdefs.c" 2019-07-07 14:33:51.068656800 +0200
+++ "/l/Program Files (x86)/Microsoft Games/Halo Custom Edition/progs/extracthalotagdefs_fix.c" 2019-07-27 12:01:20.691244400 +0200
@@ -6,10 +6,11 @@
 //  Copyright © 2018 haloserver. All rights reserved.
 //

-#import <stdio.h>
-#import <stdlib.h>
-#import <string.h>
-#import <stdbool.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+#include <stdbool.h>
+#include <stdint.h>

 const uint8_t negone[] = { 0xFF, 0xFF, 0xFF, 0xFF };
 const char* hex = "0123456789abcdef";
@@ -195,17 +196,39 @@

 struct file_data store_file(const char *path)
 {
-   struct file_data result = { 0, calloc(1, sizeof(size_t)) };
-   if (path == NULL) return result;
-   FILE* file = fopen(path, "r");
-   if (file == NULL) return result;
-   if (fseek(file, 0, SEEK_END) != 0) { fclose(file); return result; }
+   struct file_data result = {
+       .length = 0,
+       .bytes = calloc(1, sizeof(size_t))
+   };
+   if (path == NULL){
+       return result;
+   }
+   FILE* file = fopen(path, "rb");
+   if (file == NULL) {
+       fprintf(stderr, "Failed to open file %s for reading\n", path);
+       return result;
+   }
+   if (fseek(file, 0, SEEK_END) != 0) {
+       fclose(file);
+       return result;
+   }
    long filesize = ftell(file);
-   if (filesize == -1 || filesize == 0) { fclose(file); return result; }
+   if (filesize == -1 || filesize == 0) {
+       fclose(file);
+       return result;
+   }
    void *data = calloc(1, (size_t)filesize);
-   if (data == NULL)  { fclose(file); return result; }
+   if (data == NULL) {
+       fclose(file);
+       return result;
+   }
    rewind(file);
-   if (fread(data, (size_t)filesize, 1, file) != 1) { free(data); fclose(file); return result; }
+   if (fread(data, (size_t)filesize, 1, file) != 1) {
+       fprintf(stderr, "Failed to read %lu bytes\n", filesize);
+       free(data);
+       fclose(file);
+       return result;
+   }
    fclose(file);
    result.length = (size_t)filesize;
    result.bytes = data;
@@ -214,10 +237,13 @@
 // returns the number of equivalent bytes, unlike memcmp
 size_t compare_bytes(const void* given1, const void* given2, size_t length)
 {
-   if (given1 == NULL || given2 == NULL || length <= 0) return 0;
-   for (size_t i = 0; i < length; i++)
-   {
-       if (*(uint8_t*)(given1 + i) != *(uint8_t*)(given2 + i)) return i;
+   if (given1 == NULL || given2 == NULL || length <= 0) {
+       return 0;
+   }
+   for (size_t i = 0; i < length; i++) {
+       if (*(uint8_t*)(given1 + i) != *(uint8_t*)(given2 + i)){
+           return i;
+       }
    }
    return length;
 }
@@ -242,7 +268,11 @@
    if (s != NULL && *s != '\0')
    {
        char temp, *end = s + strlen(s);
-       while ( --end > s ) { temp = *s; *s++ = *end; *end=temp; }
+       while ( --end > s ) {
+           temp = *s;
+           *s++ = *end;
+           *end=temp;
+       }
    }
 }

@@ -251,14 +281,20 @@
    if (data != NULL && data_length > 1)
    {
        uint8_t temp, *point1 = data, *point2 = data + data_length;
-       while ( --point2 > point1 ) { temp = *point1; *(point1++) = *point2; *point2 = temp; }
+       while ( --point2 > point1 ) {
+           temp = *point1;
+           *(point1++) = *point2;
+           *point2 = temp;
+       }
    }
 }
 // convert static pointer address to HEK program binary offset
 // this lets me interpret all pointers as file data offsets in the file data bytes array, or use pointer math with void* bytes
 uint32_t p2o(const void* given)
 {
-   if (given == NULL) return 0;
+   if (given == NULL){
+       return 0;
+   }
    return *(uint32_t*)given - MEMREGION;
 }
 char* o2string(struct file_data file, uint32_t offset)
@@ -645,7 +681,7 @@
                for (int i = 0; i < flags.info.count; i++)
                {
                    indent(levels);
-                   printf("%s\n",o2string(file, p2o(flags.info.names) + (i * sizeof(uint32_t))));
+                   printf("%s\n", o2string(file, p2o(flags.info.names) + (i * sizeof(uint32_t))));
                }

                levels -= 1;
@@ -1561,15 +1597,21 @@
 // the purpose of this program is to output in C the tag file definitions from within an HEK program.
 int main(int argc, const char * argv[])
 {
-   @autoreleasepool
-   {
-       if (argc < 2) return 0;
+   if (argc < 2){
+       return 0;
+   }
        struct file_data file = store_file(argv[1]);
        //NSFileManager *fm = [NSFileManager new];
        //NSData *filedata = [fm contentsAtPath:[NSString stringWithCString:argv[1] encoding:NSUTF8StringEncoding]];
-       if (file.bytes == NULL) return 1;
+   if (file.bytes == NULL){
+       fprintf(stderr, "Failed to read input file %s\n", argv[1]);
+       return 1;
+   }
        // get all the tag definition file data offsets
-       if (file.length < GUERILLA_DEFS_INDEX + (83 * sizeof(uint32_t))) return 1;
+   if (file.length < GUERILLA_DEFS_INDEX + (83 * sizeof(uint32_t))){
+       fprintf(stderr, "Input file too short (file.length = %lu)\n", file.length);
+       return 1;
+   }
        uint32_t tag_def_offsets[83] = { 0 };
        printf("extracthalotagdefs and its resulting file are by sparky (e-mail:galaxyverge+halo@pm.me discord:sparky#0343 chat:https://discord.gg/mcEzrrv)\ntetelestai\ntag definitions parsed from guerilla.exe\nmodify output to suit your source code syntax needs by modifying extracthalotagdefs\nall credit to Jesus Christ for anything that pleases His Majesty, King of Glory\nnote that these definitions do not fully equate to stored file data...\nrespect me and what I freely did for you by leaving this printf statement intact\n\n");
        for (uint32_t i = 0; i < 83; i++)
@@ -1590,7 +1632,5 @@
            printf("\n");
            release(tagdef);
        }
-
-   }
     return 0;
 }