Item rando: V7 Change Notes

Changes in this version::

Pyinstaller 5 support

Features:
Randomised item assignment
Uses a series of different flags to assign to items, which the logic ignores in the same way. Unreachable used for warp-related behaviour, Banned used for allow list/ban list/modified items, whilst Impossible remains and means NEVER OVERWRITE THIS. For example, never overwrite Radio Card when playing standard.

Bike indoors patch

Spoiler file now contains version, modifiers hash and mode



Warp Logic
Generates warp data automatically based on reading from the provided roms
|- There is code to generate the labels needed to detect this, e.g. a future change to speedchoice
Warps are bidirectional and do require extra work to refine
Expect warp item rando to take a while to generate, if it takes TOO long, try another rom?


Logic:
More flags added in order to support warp rando. Some replace location requirements. Add WarpReqs to many yaml files, the main purpose of this is to replace all LocationRequirements, so some have been split up to 'Access' means, one for Warps and one for normal behaviour.
Items will be removed from logic is inaccessible due to warps.

BRICK_PIECE is given to any location provided unreachable by warp.
SILVER_LEAF is given to any location provided unreachable in general -- when randomise other items is enabled.
GOLD_LEAF is given to any location if the trash item list expires.



New Modifiers:
Warps -- enables warp behaviour
No Flash -- Removes flash logic. IFatRains Warp Rando has functionality for disbaling Flash. Can also be used for Evil settings.
No Smoke Ball -- personally hate the gates in Underground, so modifier to remove this item from logic
No E4 -- prevent items being locked behind E4
Enable Patches without Logic: -- Enable time events patches without adding them to logic
Start With Bike -- removes bike from logic, replacing with a trash item. Asssumes user enables Bike in start settings.
Upgrade Items Always -- with item replacement, add option to always upgrade without changing percentages.
Fly Warps -- Ensures fly is available before any other item is required. Truly impacted performance when generating a rom however, because both items need to be placed early in the game. With a small starting area, this may not generate a rom quickly at all. Work in progress.


New Modes:
TMs + Key Items + -- includes all TMs including those in Kanto and locked behind time events or similar alongside key items.
Fixed bug in previous TMPlusKeyItems, with incorrect name for TM18.
WarpKeyTM -- The above but with warps enabled.



Fixes:
Modifiers which ban items, such as banning Tin Tower failed to work correctly with the Mt Silver open modifier. Resolve this by making the requirement 'Red' for unlocking and assigning items.
Resolve E4 requirement in Open Mt Silver modifier.
Fix Shuffle Leftovers behaviour.
Improve Item Replacement code, as it was originally a single pass through a file, so not everything would be fully upgraded. This now picks a random item if there are multiple choices as well.
Mostly for warps, but add logic for determining items attempting to be put into Mt Silver by working out a list of places locked AFTER Mt Silver is opened, and preventing Progress items or badges from placement there.
Extreme fix with Kanto power behaviour -- but does this work with warps? May require more changes, as also need to find Directors room in Lavender, and power assumes this to be the case.

Tests:
Add tests when generating rom information, such as checking files are not missed. Fail if files are not listed from the manual labels set.
Test function for FlagsSet, ensuring that a flag is set somewhere if used by other locations in Map Data.
Test function for LocationReqs, ensuring the required area exists also in Logic, to prevent spelling errors.
Add tests for modifiers using Remove -- that they actually contain the requested requirement in the first place