Dolphin - clang warnings 3.0-776

Source/Core/Common/Src/StringUtil.cpp:142:13: warning: comparison of unsigned expression >= 0 is always true [-Wtautological-compare]
                if (value >= static_cast<unsigned long>(0x100000000ull)
                    ~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.




Source/Core/Common/Src/x64Emitter.cpp:873:7: warning: unused variable 'writeImm' [-Wunused-variable]
        bool writeImm = false;
             ^
Source/Core/Common/Src/x64Emitter.cpp:904:7: warning: unused variable 'writeImm' [-Wunused-variable]
        bool writeImm = false;
             ^
2 warnings generated.




Source/Core/Common/Src/x64Emitter.cpp:873:7: warning: unused variable 'writeImm' [-Wunused-variable]
        bool writeImm = false;
             ^
Source/Core/Common/Src/x64Emitter.cpp:904:7: warning: unused variable 'writeImm' [-Wunused-variable]
        bool writeImm = false;
             ^
2 warnings generated.




Source/Plugins/Plugin_VideoSoftware/Src/EfbInterface.cpp:358:24: warning: explicitly assigning a variable of type 'u32' (aka 'unsigned int') to itself
      [-Wself-assign]
                dstClr = dstClr;
                ~~~~~~ ^ ~~~~~~
1 warning generated.




Source/Plugins/Plugin_VideoSoftware/Src/EfbInterface.cpp:358:24: warning: explicitly assigning a variable of type 'u32' (aka 'unsigned int') to itself
      [-Wself-assign]
                dstClr = dstClr;
                ~~~~~~ ^ ~~~~~~
1 warning generated.




Source/Core/VideoCommon/Src/PixelShaderGen.cpp:629:8: warning: unused variable 'pmainstart' [-Wunused-variable]
        char* pmainstart = p;
              ^
1 warning generated.




Source/Core/VideoCommon/Src/PixelShaderGen.cpp:629:8: warning: unused variable 'pmainstart' [-Wunused-variable]
        char* pmainstart = p;
              ^
1 warning generated.




In file included from Source/Core/Core/Src/HW/DSPLLE/DSPDebugInterface.cpp:18:
Source/Core/Core/Src/HW/DSPLLE/DSPDebugInterface.h:30:15: warning: 'DSPDebugInterface::insertBLR' hides overloaded virtual function
      [-Woverloaded-virtual]
        virtual void insertBLR(unsigned int address);
                     ^
Source/Core/Common/Src/DebugInterface.h:33:15: note: hidden overloaded virtual function 'DebugInterface::insertBLR' declared here
        virtual void insertBLR(unsigned int /*address*/, unsigned int) {}
                     ^
1 warning generated.




In file included from Source/Core/Core/Src/HW/DSPLLE/DSPDebugInterface.cpp:18:
Source/Core/Core/Src/HW/DSPLLE/DSPDebugInterface.h:30:15: warning: 'DSPDebugInterface::insertBLR' hides overloaded virtual function
      [-Woverloaded-virtual]
        virtual void insertBLR(unsigned int address);
                     ^
Source/Core/Common/Src/DebugInterface.h:33:15: note: hidden overloaded virtual function 'DebugInterface::insertBLR' declared here
        virtual void insertBLR(unsigned int /*address*/, unsigned int) {}
                     ^
1 warning generated.




Source/Core/Core/Src/HW/GCMemcard.cpp:619:6: warning: unused variable 'memcardSize' [-Wunused-variable]
        u16 memcardSize = BE16(hdr.SizeMb) * MBIT_TO_BLOCKS;
            ^
1 warning generated.




Source/Core/Core/Src/HW/Memmap.cpp:661:3: warning: add explicit braces to avoid dangling else [-Wdangling-else]
                else
                ^
1 warning generated.




Source/Core/Core/Src/HW/WiimoteReal/WiimoteReal.cpp:515:9: warning: 'ARRAYSIZE' macro redefined
#define ARRAYSIZE(_arr) (sizeof(_arr)/(sizeof(_arr[0])))
        ^
Source/Core/Common/Src/CommonFuncs.h:66:10: note: previous definition is here
        #define ARRAYSIZE(A) (sizeof(A)/sizeof((A)[0]))
                ^
1 warning generated.




Source/Core/Core/Src/PowerPC/PowerPC.cpp:148:27: warning: variable '_mode' is uninitialized when used here [-Wuninitialized]
        asm ("fstcw %0" : : "m" (_mode));
                                 ^~~~~
Source/Core/Core/Src/PowerPC/PowerPC.cpp:147:22: note: initialize the variable '_mode' to silence this warning
        unsigned short _mode;
                            ^
                             = 0
1 warning generated.




Source/Core/Core/Src/PowerPC/Jit64/Jit_Integer.cpp:1390:33: warning: '&&' within '||' [-Wlogical-op-parentheses]
                if( j == 0 || i == 0x80000000 && j == -1)
                           ~~ ~~~~~~~~~~~~~~~~^~~~~~~~~~
Source/Core/Core/Src/PowerPC/Jit64/Jit_Integer.cpp:1390:33: note: place parentheses around the '&&' expression to silence this warning
                if( j == 0 || i == 0x80000000 && j == -1)
                                              ^
                              (                         )
1 warning generated.




Source/Core/Core/Src/PowerPC/Jit64/Jit_Integer.cpp:1390:33: warning: '&&' within '||' [-Wlogical-op-parentheses]
                if( j == 0 || i == 0x80000000 && j == -1)
                           ~~ ~~~~~~~~~~~~~~~~^~~~~~~~~~
Source/Core/Core/Src/PowerPC/Jit64/Jit_Integer.cpp:1390:33: note: place parentheses around the '&&' expression to silence this warning
                if( j == 0 || i == 0x80000000 && j == -1)
                                              ^
                              (                         )
1 warning generated.




In file included from Source/Core/DolphinWX/Src/CheatsWindow.cpp:26:
In file included from Source/Core/DolphinWX/Src/Frame.h:36:
Source/Core/DolphinWX/Src/TASInputDlg.h:49:8: warning: 'TASInputDlg::HasFocus' hides overloaded virtual function [-Woverloaded-virtual]
                bool HasFocus();
                     ^
Externals/wxWidgets3/include/wx/window.h:655:18: note: hidden overloaded virtual function 'wxWindowBase::HasFocus' declared here
    virtual bool HasFocus() const;
                 ^
1 warning generated.

^ This last warning repeats MANY MANY TIMES.