Not a member of Pastebin yet?
Sign Up,
it unlocks many cool features!
- I wonder if it would be appropriate to make this a syspref in Koha---have a SIP configuration, and a "use \r" or "use \n"?
- A syspref would still not allow you to use opposing client implementations simultaneously, which is what I was concerned about. Also, the line endings are interpreted by a daemon in a process that precedes DB access (that wouldn't be know to be updated when the syspref changed unless it checked with every line, killing performance).
- I applied changes that basically bring the Koha Sip.pm code closer to the current SIPServer version of the file, including the spec-compliant line-endings. Upon restarting the SIP listeners, I could successfully authenticate using the example user/passwd:
- Nov 30 22:15:27 whenua koha_sip: read_SIP_packet, INPUT MSG: '6300120040805 193113Y AOInstitutionID|AA22003000063824|AD11223344|BP00001|BQ00006|AY2AZE849'
- Nov 30 22:15:27 whenua koha_sip: read_SIP_packet, INPUT MSG: '6300120040805 193113Y AOInstitutionID|AA22003000063824|AD11223344|BP00001|BQ00006|AY2AZE849'
- Nov 30 22:15:27 whenua koha_sip: INPUT MSG: '6300120040805 193113Y AOInstitutionID|AA22003000063824|AD11223344|BP00001|BQ00006|AY2AZE849'
- Nov 30 22:15:27 whenua koha_sip: Sip::MsgType::new('Sip::MsgType', '6300120040...', '63'): seq.no '2', protocol 2
- Nov 30 22:15:27 whenua koha_sip: Sip::MsgType::_initialize('Patron Info', '00120040805 193113Y AOInstitutionID|AA22003000063824|AD11223344|BP00001|BQ00006|', 'A3A18A10', '31', ...)
- Nov 30 22:15:27 whenua koha_sip: new ILS::Patron(22003000063824): found patron '22003000063824'
- Nov 30 22:15:27 whenua koha_sip: patron_status_string: 22003000063824 charge_ok: 1
- Nov 30 22:15:27 whenua koha_sip: Summary_info: index == '0', field 'AS'
- Nov 30 22:15:27 whenua koha_sip: summary_info: list = ()
- Nov 30 22:15:27 whenua koha_sip: OUTPUT MSG: '64 00120101130 221527000000000000000000000000AOSAVANNAH|AA22003000063824|AE JUVOK PCCOP|BLY|CQY|CC.01|BD1904 N BELT HWY|BF232-5479|PB20000101|PCJUV-OK|PIY|AFGreetings from Koha. |AY2AZCDEF'
- I also tested a made-up card numbers and passwords and got appropriate responses. So everything looks clean to me.
- The next necessary test will be to confirm the operation of the remaining SIP-dependent processes. Note I did not check the "Validate PIN/password" box in the BS Authentication config.
- Greg, if you can confirm your other SIP devices are still OK, then I'll send a final writeup and submit the patch to the main Koha repo.
Add Comment
Please, Sign In to add comment