Guest User

Untitled

a guest
May 23rd, 2018
81
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
text 1.22 KB | None | 0 0
  1. diff --git a/common/src/js/webdriver/web_element.js b/common/src/js/webdriver/web_element.js
  2. index f31ae2a..5f29877 100644
  3. --- a/common/src/js/webdriver/web_element.js
  4. +++ b/common/src/js/webdriver/web_element.js
  5. @@ -114,6 +114,7 @@ webdriver.element.getAttribute = function(element, attribute) {
  6.  
  7. if (bot.dom.hasProperty(element, attribute)) {
  8. value = bot.dom.getProperty(element, attribute);
  9. + value = goog.string.isEmpty(value) ? null : value;
  10. }
  11.  
  12. if (!goog.isDef(value) && bot.dom.hasAttribute(element, attribute)) {
  13. diff --git a/common/test/js/webdriver/web_element_test.html b/common/test/js/webdriver/web_element_test.html
  14. index 332297c..30b9b9b 100644
  15. --- a/common/test/js/webdriver/web_element_test.html
  16. +++ b/common/test/js/webdriver/web_element_test.html
  17. @@ -57,6 +57,12 @@ limitations under the License.
  18. assertNull(webdriver.element.getAttribute(element, 'readonly'));
  19. }
  20.  
  21. + function testShouldReturnMissingAttributesAsNull() {
  22. + var element = bot.locators.findElement({id: 'selected-option'});
  23. +
  24. + assertNull(webdriver.element.getAttribute(element, 'label'));
  25. + }
  26. +
  27. function testSettingAnyValueForABooleanAttributeSetsItToTrue() {
  28. var element = bot.locators.findElement({id: 'bad-ro'});
Add Comment
Please, Sign In to add comment