Feedback 2.1.16

Feedback without knowing the thoughts behind the work is hard to give. I hope there will be no major misunderstandings.

Classes
------------

All seem quite relevant, what can I say, I had almost the same under different names.

Customer being an abstract class is neat, but then why is it shown in the event table? Even if B2B and B2C had the exact same pattern.

I see you also plan to handle payments in the system. It was my impression that this was a bit out of scope, but no doubt it would make sense to do. I fail to see the importance of a distinction between Cash and Dankort, however, but then again it is missing in the event table. Same goes for Invoice and Check.

Events
------------

Your pattern of New Reservation -> Cancel/Pickup -> Return is very neat.

Events mostly allright, though I don't understand why it is important for the system to be able to do credit checks. You will notice in the Event Table that it links only to one class, and I don't think such things are generally automated.

Event Table
------------

Looking over it, one can see that it actually has a fine distribution of links. The exception being that Car is attached to everything, but I think that the consensus is that this is mostly unavoidable. (Only thing one can argue, like he did in the lecture, is that Car should not be part of reservations, but only the fact that one is available in the price group. I wouldn't say that'd be objectively better though.)

I would like to know why Montly Payment is only linked to New Reservation. If nothing else, what if the reservation is cancelled?

The opposite goes for Deposit Difference; Did you mean for it to be at Pickup instead?

Does the Deposit class not care that the car is returned?

Is Reservation still relevant at Car Return, Repair Car, and Send Reciept? Perhaps the class' purpose is being stretched, or perhaps it has been given a wrong name.

Does the Station not care that a Car of its has been sold?

Structure
------------

So each station is made up of a series of Reservations, which in turn are from the one class to rule them all.

Each Reservation object is made up of information about the customer, the payment-type, deposit difference and the desired car. The Reservation will then have different states(not shown) depending on whether the car has just been reserved, picked up or even returned but not paid for.

This is a bit of a convoluted setup, and I think one would do well to rethink it before trying to implement such a system. Both for reasons of understanding but also for technical reasons. What is the program to do if it wishes to know which cars are available? Iterate through reservations and subtract the resulting list of cars in use from the full inventory?