Advertisement
Not a member of Pastebin yet?
Sign Up,
it unlocks many cool features!
- diff -r b227a707080f mobile/android/base/tests/PixelTest.java
- --- a/mobile/android/base/tests/PixelTest.java Wed Apr 30 13:15:46 2014 -0400
- +++ b/mobile/android/base/tests/PixelTest.java Wed Apr 30 19:51:24 2014 -0700
- @@ -29,8 +29,8 @@
- Actions.RepeatedEventExpecter paintExpecter = mActions.expectPaint();
- mActions.sendSpecialKey(Actions.SpecialKey.MENU);
- - waitForText("Reload");
- - mSolo.clickOnText("Reload");
- + waitForText(StringHelper.RELOAD_LABEL);
- + mSolo.clickOnText(StringHelper.RELOAD_LABEL);
- paintExpecter.blockUntilClear(PAINT_CLEAR_DELAY);
- paintExpecter.unregisterListener();
- diff -r b227a707080f mobile/android/base/tests/SessionTest.java
- --- a/mobile/android/base/tests/SessionTest.java Wed Apr 30 13:15:46 2014 -0400
- +++ b/mobile/android/base/tests/SessionTest.java Wed Apr 30 19:51:24 2014 -0700
- @@ -132,7 +132,7 @@
- protected void loadSessionTabs(Session session) {
- // Verify initial about:home tab
- verifyTabCount(1);
- - verifyUrl("about:home");
- + verifyUrl(StringHelper.ABOUT_HOME_URL);
- SessionTab[] tabs = session.getItems();
- for (int i = 0; i < tabs.length; i++) {
- @@ -141,7 +141,7 @@
- // New tabs always start with about:home, so make sure about:home
- // is always the first entry.
- - mAsserter.is(pages[0].url, "about:home", "first page in tab is about:home");
- + mAsserter.is(pages[0].url, StringHelper.ABOUT_HOME_URL, "first page in tab is about:home");
- // If this is the first tab, the tab already exists, so no need to
- // create a new one. Otherwise, create a new tab if we're loading
- @@ -194,7 +194,7 @@
- (new NavigationWalker<PageInfo>(tab) {
- @Override
- public void onItem(PageInfo page, int currentIndex) {
- - if (page.url.equals("about:home")) {
- + if (page.url.equals(StringHelper.ABOUT_HOME_URL)) {
- waitForText("Enter Search or Address");
- verifyUrl(page.url);
- } else {
- diff -r b227a707080f mobile/android/base/tests/StringHelper.java
- --- a/mobile/android/base/tests/StringHelper.java Wed Apr 30 13:15:46 2014 -0400
- +++ b/mobile/android/base/tests/StringHelper.java Wed Apr 30 19:51:24 2014 -0700
- @@ -18,44 +18,63 @@
- // About pages
- public static final String ABOUT_BLANK_URL = "about:blank";
- public static final String ABOUT_FIREFOX_URL = "about:firefox";
- + public static final String ABOUT_RIGHTS_URL = "about:rights";
- + public static final String ABOUT_BUILDCONFIG_URL = "about:buildconfig";
- + public static final String ABOUT_HEALTHREPORT_URL = "about:healthreport";
- public static final String ABOUT_DOWNLOADS_URL = "about:downloads";
- public static final String ABOUT_HOME_URL = "about:home";
- public static final String ABOUT_ADDONS_URL = "about:addons";
- public static final String ABOUT_APPS_URL = "about:apps";
- + public static final String ABOUT_ABOUT_URL = "about:about";
- + public static final String ABOUT_URL = "about:";
- // About pages' titles
- public static final String ABOUT_HOME_TITLE = "";
- + // Context Menu item strings
- + public static final CONTEXT_MENU_BOOKMARK_LINK = "Bookmark Link";
- + public static final CONTEXT_MENU_OPEN_LINK_IN_NEW_TAB = "Open Link in New Tab";
- + public static final CONTEXT_MENU_OPEN_LINK_IN_PRIVATE_TAB = "Open Link in Private Tab";
- + public static final CONTEXT_MENU_COPY_LINK = "Copy Link";
- + public static final CONTEXT_MENU_SHARE_LINK = "Share Link";
- + public static final CONTEXT_MENU_BOOKMARK_LINK = "Bookmark Link";
- + public static final CONTEXT_MENU_EDIT = "Edit";
- + public static final CONTEXT_MENU_SHARE = "Share";
- + public static final CONTEXT_MENU_REMOVE = "Remove";
- + public static final CONTEXT_MENU_COPY_ADDRESS = "Copy Address";
- + public static final CONTEXT_MENU_EDIT_SITE_SETTINGS = "Edit Site Settings";
- + public static final CONTEXT_MENU_ADD_TO_HOME_SCREEN = "Add to Home Screen";
- +
- // Context Menu menu items
- public static final String[] CONTEXT_MENU_ITEMS_IN_PRIVATE_TAB = new String[] {
- - "Open Link in Private Tab",
- - "Copy Link",
- - "Share Link",
- - "Bookmark Link"
- + CONTEXT_MENU_OPEN_LINK_IN_PRIVATE_TAB,
- + CONTEXT_MENU_COPY_LINK,
- + CONTEXT_MENU_SHARE_LINK,
- + CONTEXT_MENU_BOOKMARK_LINK
- };
- public static final String[] CONTEXT_MENU_ITEMS_IN_NORMAL_TAB = new String[] {
- - "Open Link in New Tab",
- - "Open Link in Private Tab",
- - "Copy Link",
- - "Share Link",
- - "Bookmark Link"
- + CONTEXT_MENU_OPEN_LINK_IN_NEW_TAB,
- + CONTEXT_MENU_OPEN_LINK_IN_PRIVATE_TAB,
- + CONTEXT_MENU_COPY_LINK,
- + CONTEXT_MENU_SHARE_LINK,
- + CONTEXT_MENU_BOOKMARK_LINK
- };
- public static final String[] BOOKMARK_CONTEXT_MENU_ITEMS = new String[] {
- - "Open in New Tab",
- - "Open in Private Tab",
- - "Edit",
- - "Remove",
- - "Share",
- - "Add to Home Screen"
- + CONTEXT_MENU_OPEN_LINK_IN_NEW_TAB,
- + CONTEXT_MENU_OPEN_LINK_IN_PRIVATE_TAB,
- + CONTEXT_MENU_EDIT,
- + CONTEXT_MENU_REMOVE,
- + CONTEXT_MENU_SHARE,
- + CONTEXT_MENU_ADD_TO_HOME_SCREEN
- };
- public static final String[] CONTEXT_MENU_ITEMS_IN_URL_BAR = new String[] {
- - "Share",
- - "Copy Address",
- - "Edit Site Settings",
- - "Add to Home Screen"
- + CONTEXT_MENU_SHARE,
- + CONTEXT_MENU_COPY_ADDRESS,
- + CONTEXT_MENU_EDIT_SITE_SETTINGS,
- + CONTEXT_MENU_ADD_TO_HOME_SCREEN
- };
- public static final String TITLE_PLACE_HOLDER = "Enter Search or Address";
- @@ -67,6 +86,8 @@
- public static final String ROBOCOP_BLANK_PAGE_01_URL = "/robocop/robocop_blank_01.html";
- public static final String ROBOCOP_BLANK_PAGE_02_URL = "/robocop/robocop_blank_02.html";
- public static final String ROBOCOP_BLANK_PAGE_03_URL = "/robocop/robocop_blank_03.html";
- + public static final String ROBOCOP_BLANK_PAGE_04_URL = "/robocop/robocop_blank_04.html";
- + public static final String ROBOCOP_BLANK_PAGE_05_URL = "/robocop/robocop_blank_05.html";
- public static final String ROBOCOP_BOXES_URL = "/robocop/robocop_boxes.html";
- public static final String ROBOCOP_GEOLOCATION_URL = "/robocop/robocop_geolocation.html";
- public static final String ROBOCOP_LOGIN_URL = "/robocop/robocop_login.html";
- @@ -84,6 +105,8 @@
- public static final String ROBOCOP_BLANK_PAGE_01_TITLE = "Browser Blank Page 01";
- public static final String ROBOCOP_BLANK_PAGE_02_TITLE = "Browser Blank Page 02";
- public static final String ROBOCOP_BLANK_PAGE_03_TITLE = "Browser Blank Page 03";
- + public static final String ROBOCOP_BLANK_PAGE_04_TITLE = "Browser Blank Page 04";
- + public static final String ROBOCOP_BLANK_PAGE_05_TITLE = "Browser Blank Page 05";
- public static final String ROBOCOP_BOXES_TITLE = "Browser Box test";
- public static final String ROBOCOP_GEOLOCATION_TITLE = "Geolocation Test Page";
- public static final String ROBOCOP_LOGIN_TITLE = "Robocop Login";
- @@ -123,16 +146,17 @@
- public static final String TRACKING_LABEL = "Tracking";
- public static final String COOKIES_LABEL = "Cookies";
- public static final String REMEMBER_PASSWORDS_LABEL = "Remember passwords";
- - public static final String MASTER_PASWSWORD_LABEL = "Use master password";
- + public static final String MASTER_PASSWORD_LABEL = "Use master password";
- public static final String CLEAR_PRIVATE_DATA_LABEL = "Clear private data";
- // Mozilla
- - public static final String ABOUT_LABEL = "About (Fennec|Nightly|Aurora|Firefox Beta|Firefox)";
- + public static final String BRAND_NAME = "(Fennec|Nightly|Aurora|Firefox Beta|Firefox)";
- + public static final String ABOUT_LABEL = "About " + BRAND_NAME;
- public static final String FAQS_LABEL = "FAQs";
- public static final String FEEDBACK_LABEL = "Give feedback";
- public static final String PRODUCT_ANNOUNCEMENTS_LABEL = "Show product announcements";
- public static final String LOCATION_SERVICES_LABEL = "Mozilla location services";
- - public static final String HELTH_REPORT_LABEL = "(Fennec|Nightly|Aurora|Firefox Beta|Firefox) Health Report";
- + public static final String HELTH_REPORT_LABEL = BRAND_NAME + " Health Report";
- public static final String MY_HEALTH_REPORT_LABEL = "View my Health Report";
- // Developer tools
- diff -r b227a707080f mobile/android/base/tests/testAboutPage.java
- --- a/mobile/android/base/tests/testAboutPage.java Wed Apr 30 13:15:46 2014 -0400
- +++ b/mobile/android/base/tests/testAboutPage.java Wed Apr 30 19:51:24 2014 -0700
- @@ -22,20 +22,20 @@
- String url = "about:";
- loadAndPaint(url);
- - ensureTitleMatches("About (Fennec|Nightly|Aurora|Firefox|Firefox Beta)");
- + ensureTitleMatches(StringHelper.ABOUT_LABEL);
- // Open a new page to remove the about: page from the current tab.
- - url = getAbsoluteUrl("/robocop/robocop_blank_01.html");
- + url = getAbsoluteUrl(StringHelper.ROBOCOP_BLANK_PAGE_01_URL);
- inputAndLoadUrl(url);
- // At this point the page title should have been set.
- - ensureTitleMatches("Browser Blank Page 01");
- + ensureTitleMatches(StringHelper.ROBOCOP_BLANK_PAGE_01_TITLE);
- // Set up listeners to catch the page load we're about to do.
- Actions.EventExpecter tabEventExpecter = mActions.expectGeckoEvent("Tab:Added");
- Actions.EventExpecter contentEventExpecter = mActions.expectGeckoEvent("DOMContentLoaded");
- - selectSettingsItem("Mozilla", "About (Fennec|Nightly|Aurora|Firefox|Firefox Beta)");
- + selectSettingsItem(StringHelper.MOZILLA_SECTION_LABEL, StringHelper.ABOUT_LABEL);
- // Wait for the new tab and page to load
- tabEventExpecter.blockForEvent();
- @@ -45,6 +45,6 @@
- contentEventExpecter.unregisterListener();
- // Grab the title to make sure the about: page was loaded.
- - ensureTitleMatches("About (Fennec|Nightly|Aurora|Firefox|Firefox Beta)");
- + ensureTitleMatches(StringHelper.ABOUT_LABEL);
- }
- }
- diff -r b227a707080f mobile/android/base/tests/testAddonManager.java
- --- a/mobile/android/base/tests/testAddonManager.java Wed Apr 30 13:15:46 2014 -0400
- +++ b/mobile/android/base/tests/testAddonManager.java Wed Apr 30 19:51:24 2014 -0700
- @@ -15,12 +15,12 @@
- public void testAddonManager() {
- Actions.EventExpecter tabEventExpecter;
- Actions.EventExpecter contentEventExpecter;
- - String url = "about:addons";
- + String url = StringHelper.ABOUT_ADDONS_URL;
- blockForGeckoReady();
- // Use the menu to open the Addon Manger
- - selectMenuItem("Add-ons");
- + selectMenuItem(StringHelper.ADDONS_LABEL);
- // Set up listeners to catch the page load we're about to do
- tabEventExpecter = mActions.expectGeckoEvent("Tab:Added");
- @@ -34,21 +34,21 @@
- contentEventExpecter.unregisterListener();
- // Verify the url
- - verifyPageTitle("Add-ons");
- + verifyPageTitle(StringHelper.ADDONS_LABEL);
- // Close the Add-on Manager
- mActions.sendSpecialKey(Actions.SpecialKey.BACK);
- // Load the about:addons page and verify it was loaded
- loadAndPaint(url);
- - verifyPageTitle("Add-ons");
- + verifyPageTitle(StringHelper.ADDONS_LABEL);
- // Change the AMO URL so we do not try to navigate to a live webpage
- JSONObject jsonPref = new JSONObject();
- try {
- jsonPref.put("name", "extensions.getAddons.browseAddons");
- jsonPref.put("type", "string");
- - jsonPref.put("value", getAbsoluteUrl("/robocop/robocop_blank_01.html"));
- + jsonPref.put("value", getAbsoluteUrl(StringHelper.ROBOCOP_BLANK_PAGE_01_URL));
- setPreferenceAndWaitForChange(jsonPref);
- } catch (Exception ex) {
- @@ -83,10 +83,10 @@
- verifyTabCount(2);
- // Verify the page was opened
- - verifyPageTitle("Browser Blank Page 01");
- + verifyPageTitle(StringHelper.ROBOCOP_BLANK_PAGE_01_TITLE);
- // Addons Manager is not opened 2 separate times when opened from the menu
- - selectMenuItem("Add-ons");
- + selectMenuItem(StringHelper.ADDONS_LABEL);
- // Verify tab count not increased
- verifyTabCount(2);
- diff -r b227a707080f mobile/android/base/tests/testAwesomebar.java
- --- a/mobile/android/base/tests/testAwesomebar.java Wed Apr 30 13:15:46 2014 -0400
- +++ b/mobile/android/base/tests/testAwesomebar.java Wed Apr 30 19:51:24 2014 -0700
- @@ -4,7 +4,7 @@
- public void testAwesomebar() {
- blockForGeckoReady();
- - String url = getAbsoluteUrl("/robocop/robocop_blank_01.html");
- + String url = getAbsoluteUrl(StringHelper.ROBOCOP_BLANK_PAGE_01_URL);
- inputAndLoadUrl(url);
- mDriver.setupScrollHandling();
- diff -r b227a707080f mobile/android/base/tests/testAxisLocking.java
- --- a/mobile/android/base/tests/testAxisLocking.java Wed Apr 30 13:15:46 2014 -0400
- +++ b/mobile/android/base/tests/testAxisLocking.java Wed Apr 30 19:51:24 2014 -0700
- @@ -13,7 +13,7 @@
- */
- public class testAxisLocking extends PixelTest {
- public void testAxisLocking() {
- - String url = getAbsoluteUrl("/robocop/robocop_boxes.html");
- + String url = getAbsoluteUrl(StringHelper.ROBOCOP_BOXES_URL);
- MotionEventHelper meh = new MotionEventHelper(getInstrumentation(), mDriver.getGeckoLeft(), mDriver.getGeckoTop());
- diff -r b227a707080f mobile/android/base/tests/testBookmarksPanel.java
- --- a/mobile/android/base/tests/testBookmarksPanel.java Wed Apr 30 13:15:46 2014 -0400
- +++ b/mobile/android/base/tests/testBookmarksPanel.java Wed Apr 30 19:51:24 2014 -0700
- @@ -51,7 +51,7 @@
- // Test that "Remove" works
- openBookmarkContextMenu(editedBookmarkValues[1]);
- mSolo.clickOnText(StringHelper.BOOKMARK_CONTEXT_MENU_ITEMS[3]);
- - waitForText("Bookmark removed");
- + waitForText(StringHelper.BOOKMARK_REMOVED_LABEL);
- mAsserter.ok(!mDatabaseHelper.isBookmark(editedBookmarkValues[1]), "Checking that the bookmark was removed", "The bookmark was removed");
- }
- @@ -61,7 +61,7 @@
- */
- private void editBookmark(String bookmarkUrl, String[] values) {
- openBookmarkContextMenu(bookmarkUrl);
- - mSolo.clickOnText("Edit");
- + mSolo.clickOnText(StringHelper.BOOKMARK_CONTEXT_MENU_ITEMS[2]);
- waitForText("Edit Bookmark");
- // Update the fields with the new values
- @@ -72,7 +72,7 @@
- }
- mSolo.clickOnButton("OK");
- - waitForText("Bookmark updated");
- + waitForText(StringHelper.BOOKMARK_UPDATED_LABEL);
- }
- /**
- @@ -81,7 +81,7 @@
- */
- private void checkBookmarkEdit(String bookmarkUrl, String[] values) {
- openBookmarkContextMenu(bookmarkUrl);
- - mSolo.clickOnText("Edit");
- + mSolo.clickOnText(StringHelper.BOOKMARK_CONTEXT_MENU_ITEMS[2]);
- waitForText("Edit Bookmark");
- // Check the values of the fields
- @@ -90,6 +90,6 @@
- }
- mSolo.clickOnButton("Cancel");
- - waitForText("BOOKMARKS");
- + waitForText(StringHelper.BOOKMARKS_LABEL);
- }
- }
- diff -r b227a707080f mobile/android/base/tests/testDoorHanger.java
- --- a/mobile/android/base/tests/testDoorHanger.java Wed Apr 30 13:15:46 2014 -0400
- +++ b/mobile/android/base/tests/testDoorHanger.java Wed Apr 30 19:51:24 2014 -0700
- @@ -14,10 +14,10 @@
- */
- public class testDoorHanger extends BaseTest {
- public void testDoorHanger() {
- - String GEO_URL = getAbsoluteUrl("/robocop/robocop_geolocation.html");
- - String BLANK_URL = getAbsoluteUrl("/robocop/robocop_blank_01.html");
- - String OFFLINE_STORAGE_URL = getAbsoluteUrl("/robocop/robocop_offline_storage.html");
- - String LOGIN_URL = getAbsoluteUrl("/robocop/robocop_login.html");
- + String GEO_URL = getAbsoluteUrl(StringHelper.ROBOCOP_GEOLOCATION_URL);
- + String BLANK_URL = getAbsoluteUrl(StringHelper.ROBOCOP_BLANK_PAGE_01_URL);
- + String OFFLINE_STORAGE_URL = getAbsoluteUrl(StringHelper.ROBOCOP_OFFLINE_STORAGE_URL);
- + String LOGIN_URL = getAbsoluteUrl(StringHelper.ROBOCOP_LOGIN_URL);
- // Strings used in doorhanger messages and buttons
- String GEO_MESSAGE = "Share your location with";
- diff -r b227a707080f mobile/android/base/tests/testFindInPage.java
- --- a/mobile/android/base/tests/testFindInPage.java Wed Apr 30 13:15:46 2014 -0400
- +++ b/mobile/android/base/tests/testFindInPage.java Wed Apr 30 19:51:24 2014 -0700
- @@ -12,7 +12,7 @@
- public void testFindInPage() {
- blockForGeckoReady();
- - String url = getAbsoluteUrl("/robocop/robocop_text_page.html");
- + String url = getAbsoluteUrl(StringHelper.ROBOCOP_TEXT_PAGE_URL);
- loadAndPaint(url);
- // Select the upper left corner of the screen
- @@ -45,7 +45,7 @@
- }
- public void findText(String text, int nrOfMatches){
- - selectMenuItem("Find in Page");
- + selectMenuItem(StringHelper.FIND_IN_PAGE_LABEL);
- close = mDriver.findElement(getActivity(), R.id.find_close);
- boolean success = waitForTest ( new BooleanTest() {
- public boolean test() {
- diff -r b227a707080f mobile/android/base/tests/testFlingCorrectness.java
- --- a/mobile/android/base/tests/testFlingCorrectness.java Wed Apr 30 13:15:46 2014 -0400
- +++ b/mobile/android/base/tests/testFlingCorrectness.java Wed Apr 30 19:51:24 2014 -0700
- @@ -11,7 +11,7 @@
- */
- public class testFlingCorrectness extends PixelTest {
- public void testFlingCorrectness() {
- - String url = getAbsoluteUrl("/robocop/robocop_boxes.html");
- + String url = getAbsoluteUrl(StringHelper.ROBOCOP_BOXES_URL);
- MotionEventHelper meh = new MotionEventHelper(getInstrumentation(), mDriver.getGeckoLeft(), mDriver.getGeckoTop());
- diff -r b227a707080f mobile/android/base/tests/testHistory.java
- --- a/mobile/android/base/tests/testHistory.java Wed Apr 30 13:15:46 2014 -0400
- +++ b/mobile/android/base/tests/testHistory.java Wed Apr 30 19:51:24 2014 -0700
- @@ -10,16 +10,16 @@
- public void testHistory() {
- blockForGeckoReady();
- - String url = getAbsoluteUrl("/robocop/robocop_blank_01.html");
- - String url2 = getAbsoluteUrl("/robocop/robocop_blank_02.html");
- - String url3 = getAbsoluteUrl("/robocop/robocop_blank_03.html");
- + String url = getAbsoluteUrl(StringHelper.ROBOCOP_BLANK_PAGE_01_URL);
- + String url2 = getAbsoluteUrl(StringHelper.ROBOCOP_BLANK_PAGE_02_URL);
- + String url3 = getAbsoluteUrl(StringHelper.ROBOCOP_BLANK_PAGE_03_URL);
- inputAndLoadUrl(url);
- - verifyPageTitle("Browser Blank Page 01");
- + verifyPageTitle(StringHelper.ROBOCOP_BLANK_PAGE_01_URL);
- inputAndLoadUrl(url2);
- - verifyPageTitle("Browser Blank Page 02");
- + verifyPageTitle(StringHelper.ROBOCOP_BLANK_PAGE_02_URL);
- inputAndLoadUrl(url3);
- - verifyPageTitle("Browser Blank Page 03");
- + verifyPageTitle(StringHelper.ROBOCOP_BLANK_PAGE_03_URL);
- openAboutHomeTab(AboutHomeTabs.MOST_RECENT);
- @@ -60,7 +60,7 @@
- // The first item here (since it was just visited) should be a "Switch to tab" item
- // i.e. don't expect a DOMCOntentLoaded event
- - verifyPageTitle("Browser Blank Page 03");
- + verifyPageTitle(StringHelper.ROBOCOP_BLANK_PAGE_03_URL);
- verifyUrl(url3);
- }
- }
- diff -r b227a707080f mobile/android/base/tests/testHomeBanner.java
- --- a/mobile/android/base/tests/testHomeBanner.java Wed Apr 30 13:15:46 2014 -0400
- +++ b/mobile/android/base/tests/testHomeBanner.java Wed Apr 30 19:51:24 2014 -0700
- @@ -41,7 +41,7 @@
- // Load about:home and make sure the onshown handler is called.
- Actions.EventExpecter eventExpecter = getActions().expectGeckoEvent("TestHomeBanner:MessageShown");
- addBannerMessage();
- - NavigationHelper.enterAndLoadUrl("about:home");
- + NavigationHelper.enterAndLoadUrl(StringHelper.ABOUT_HOME_URL);
- eventExpecter.blockForEvent();
- // Verify that the banner is visible with the correct text.
- @@ -53,7 +53,7 @@
- eventExpecter.blockForEvent();
- // Verify that the banner isn't visible after navigating away from about:home.
- - NavigationHelper.enterAndLoadUrl("about:firefox");
- + NavigationHelper.enterAndLoadUrl(StringHelper.ABOUT_FIREFOX_URL);
- mAboutHome.assertBannerNotVisible();
- }
- @@ -68,7 +68,7 @@
- removeBannerMessage();
- // Verify that the banner no longer appears.
- - NavigationHelper.enterAndLoadUrl("about:home");
- + NavigationHelper.enterAndLoadUrl(StringHelper.ABOUT_HOME_URL);
- mAboutHome.assertVisible()
- .assertBannerNotVisible();
- }
- @@ -83,7 +83,7 @@
- // Add back the banner message to test the dismiss functionality.
- addBannerMessage();
- - NavigationHelper.enterAndLoadUrl("about:home");
- + NavigationHelper.enterAndLoadUrl(StringHelper.ABOUT_HOME_URL);
- mAboutHome.assertVisible();
- // Test to make sure the ondismiss handler is called when the close button is clicked.
- @@ -95,7 +95,7 @@
- }
- private void hideOnToolbarFocusTest() {
- - NavigationHelper.enterAndLoadUrl("about:home");
- + NavigationHelper.enterAndLoadUrl(StringHelper.ABOUT_HOME_URL);
- mAboutHome.assertVisible()
- .assertBannerVisible();
- diff -r b227a707080f mobile/android/base/tests/testImportFromAndroid.java
- --- a/mobile/android/base/tests/testImportFromAndroid.java Wed Apr 30 13:15:46 2014 -0400
- +++ b/mobile/android/base/tests/testImportFromAndroid.java Wed Apr 30 19:51:24 2014 -0700
- @@ -130,7 +130,7 @@
- }
- private void importDataFromAndroid() {
- - waitForText("Enter Search or Address");
- + waitForText(StringHelper.TITLE_PLACE_HOLDER);
- selectSettingsItem(StringHelper.CUSTOMIZE_SECTION_LABEL, StringHelper.IMPORT_FROM_ANDROID_LABEL);
- // Wait for the Import form Android pop-up to be opened. It has the same title as the option so waiting for the "Cancel" button
- @@ -152,10 +152,10 @@
- waitForText(StringHelper.IMPORT_FROM_ANDROID_LABEL);
- mActions.sendSpecialKey(Actions.SpecialKey.BACK);
- }
- - waitForText("Privacy"); // Settings is a header for the settings menu page. Waiting for Privacy ensures we are back in the top Settings view
- + waitForText(StringHelper.PRIVARY_SECTION_LABEL); // Settings is a header for the settings menu page. Waiting for Privacy ensures we are back in the top Settings view
- mActions.sendSpecialKey(Actions.SpecialKey.BACK); // Exit Settings
- // Make sure the settings menu has been closed.
- - mAsserter.ok(mSolo.waitForText("Enter Search or Address"), "Waiting for search bar", "Search bar found");
- + mAsserter.ok(mSolo.waitForText(StringHelper.TITLE_PLACE_HOLDER), "Waiting for search bar", "Search bar found");
- }
- diff -r b227a707080f mobile/android/base/tests/testInputUrlBar.java
- --- a/mobile/android/base/tests/testInputUrlBar.java Wed Apr 30 13:15:46 2014 -0400
- +++ b/mobile/android/base/tests/testInputUrlBar.java Wed Apr 30 19:51:24 2014 -0700
- @@ -19,7 +19,7 @@
- blockForGeckoReady();
- startEditingMode();
- - assertUrlBarText("about:home");
- + assertUrlBarText(StringHelper.ABOUT_HOME_URL);
- // Avoid any auto domain completion by using a prefix that matches
- // nothing, including about: pages
- @@ -85,11 +85,11 @@
- // Dismiss editing mode
- mActions.sendSpecialKey(Actions.SpecialKey.BACK);
- - waitForText("Enter Search or Address");
- + waitForText(StringHelper.TITLE_PLACE_HOLDER);
- // URL bar should have forgotten about "uv" text.
- startEditingMode();
- - assertUrlBarText("about:home");
- + assertUrlBarText(StringHelper.ABOUT_HOME_URL);
- int width = mDriver.getGeckoWidth() / 2;
- int y = mDriver.getGeckoHeight() / 2;
- diff -r b227a707080f mobile/android/base/tests/testLinkContextMenu.java
- --- a/mobile/android/base/tests/testLinkContextMenu.java Wed Apr 30 13:15:46 2014 -0400
- +++ b/mobile/android/base/tests/testLinkContextMenu.java Wed Apr 30 19:51:24 2014 -0700
- @@ -7,13 +7,13 @@
- private static String LINK_PAGE_URL;
- private static String BLANK_PAGE_URL;
- private static final String LINK_PAGE_TITLE = "Big Link";
- - private static final String linkMenuItems [] = { "Open Link in New Tab", "Open Link in Private Tab", "Copy Link", "Share Link", "Bookmark Link"};
- + private static final String linkMenuItems [] = StringHelper.CONTEXT_MENU_ITEMS_IN_NORMAL_TAB;
- public void testLinkContextMenu() {
- blockForGeckoReady();
- - LINK_PAGE_URL=getAbsoluteUrl("/robocop/robocop_big_link.html");
- - BLANK_PAGE_URL=getAbsoluteUrl("/robocop/robocop_blank_01.html");
- + LINK_PAGE_URL=getAbsoluteUrl(StringHelper.ROBOCOP_BIG_LINK_URL);
- + BLANK_PAGE_URL=getAbsoluteUrl(StringHelper.ROBOCOP_BLANK_PAGE_01_URL);
- inputAndLoadUrl(LINK_PAGE_URL);
- waitForText(LINK_PAGE_TITLE);
- diff -r b227a707080f mobile/android/base/tests/testLoad.java
- --- a/mobile/android/base/tests/testLoad.java Wed Apr 30 13:15:46 2014 -0400
- +++ b/mobile/android/base/tests/testLoad.java Wed Apr 30 19:51:24 2014 -0700
- @@ -8,7 +8,7 @@
- */
- public class testLoad extends PixelTest {
- public void testLoad() {
- - String url = getAbsoluteUrl("/robocop/robocop_boxes.html");
- + String url = getAbsoluteUrl(StringHelper.ROBOCOP_BOXES_URL);
- blockForGeckoReady();
- diff -r b227a707080f mobile/android/base/tests/testMailToContextMenu.java
- --- a/mobile/android/base/tests/testMailToContextMenu.java Wed Apr 30 13:15:46 2014 -0400
- +++ b/mobile/android/base/tests/testMailToContextMenu.java Wed Apr 30 19:51:24 2014 -0700
- @@ -5,13 +5,13 @@
- // Test website strings
- private static String MAILTO_PAGE_URL;
- - private static final String MAILTO_PAGE_TITLE = "Big Mailto";
- + private static final String MAILTO_PAGE_TITLE = StringHelper.ROBOCOP_BIG_MAILTO_TITLE;
- private static final String mailtoMenuItems [] = {"Copy Email Address", "Share Email Address"};
- public void testMailToContextMenu() {
- blockForGeckoReady();
- - MAILTO_PAGE_URL=getAbsoluteUrl("/robocop/robocop_big_mailto.html");
- + MAILTO_PAGE_URL=getAbsoluteUrl(StringHelper.ROBOCOP_BIG_MAILTO_URL);
- inputAndLoadUrl(MAILTO_PAGE_URL);
- waitForText(MAILTO_PAGE_TITLE);
- diff -r b227a707080f mobile/android/base/tests/testMasterPassword.java
- --- a/mobile/android/base/tests/testMasterPassword.java Wed Apr 30 13:15:46 2014 -0400
- +++ b/mobile/android/base/tests/testMasterPassword.java Wed Apr 30 19:51:24 2014 -0700
- @@ -22,7 +22,7 @@
- public void enableMasterPassword(String password, String badPassword) {
- // Look for the 'Settings' menu if this device/OS uses it
- - selectSettingsItem("Privacy", "Use master password");
- + selectSettingsItem(StringHelper.PRIVACY_SECTION_LABEL, "Use master password");
- waitForText("^Create Master Password$");
- // Verify that the OK button is not activated until both fields are filled
- @@ -75,14 +75,14 @@
- waitForText("Use master password");
- mActions.sendSpecialKey(Actions.SpecialKey.BACK);
- }
- - waitForText("Settings");
- + waitForText(StringHelper.SETTINGS_LABEL);
- mActions.sendSpecialKey(Actions.SpecialKey.BACK);// Close the Settings Menu
- }
- public void disableMasterPassword(String password, String badPassword) {
- // Look for the 'Settings' menu if this device/OS uses it
- - selectSettingsItem("Privacy", "Use master password");
- + selectSettingsItem(StringHelper.PRIVACY_SECTION_LABEL, "Use master password");
- waitForText("^Remove Master Password$");
- // Verify that the OK button is not activated if the password field is empty
- @@ -139,7 +139,7 @@
- public void clearPrivateData() {
- // Look for the 'Settings' menu if this device/OS uses it
- - selectSettingsItem("Privacy", "Clear private data");
- + selectSettingsItem(StringHelper.PRIVACY_SECTION_LABEL, "Clear private data");
- waitForText("Browsing history"); // Make sure the Clear private data pop-up is displayed
- Actions.EventExpecter clearPrivateDataEventExpecter = mActions.expectGeckoEvent("Sanitize:Finished");
- @@ -168,7 +168,7 @@
- waitForText("Use master password");
- mActions.sendSpecialKey(Actions.SpecialKey.BACK);
- }
- - waitForText("Settings");
- + waitForText(StringHelper.SETTINGS_LABEL);
- mActions.sendSpecialKey(Actions.SpecialKey.BACK);// Close the Settings Menu
- // Make sure the settings menu has been closed.
- mAsserter.ok(mSolo.waitForText("Browser Blank Page 01"), "Waiting for blank browser page after exiting settings", "Blank browser page present");
- diff -r b227a707080f mobile/android/base/tests/testNewTab.java
- --- a/mobile/android/base/tests/testNewTab.java Wed Apr 30 13:15:46 2014 -0400
- +++ b/mobile/android/base/tests/testNewTab.java Wed Apr 30 19:51:24 2014 -0700
- @@ -15,8 +15,8 @@
- private int tabCountInt = 0;
- public void testNewTab() {
- - String url = getAbsoluteUrl("/robocop/robocop_blank_01.html");
- - String url2 = getAbsoluteUrl("/robocop/robocop_blank_02.html");
- + String url = getAbsoluteUrl(StringHelper.ROBOCOP_BLANK_PAGE_01_URL);
- + String url2 = getAbsoluteUrl(StringHelper.ROBOCOP_BLANK_PAGE_02_URL);
- blockForGeckoReady();
- diff -r b227a707080f mobile/android/base/tests/testOverscroll.java
- --- a/mobile/android/base/tests/testOverscroll.java Wed Apr 30 13:15:46 2014 -0400
- +++ b/mobile/android/base/tests/testOverscroll.java Wed Apr 30 19:51:24 2014 -0700
- @@ -11,7 +11,7 @@
- */
- public class testOverscroll extends PixelTest {
- public void testOverscroll() {
- - String url = getAbsoluteUrl("/robocop/robocop_boxes.html");
- + String url = getAbsoluteUrl(StringBuilder.ROBOCOP_BOXES_URL);
- MotionEventHelper meh = new MotionEventHelper(getInstrumentation(), mDriver.getGeckoLeft(), mDriver.getGeckoTop());
- diff -r b227a707080f mobile/android/base/tests/testPanCorrectness.java
- --- a/mobile/android/base/tests/testPanCorrectness.java Wed Apr 30 13:15:46 2014 -0400
- +++ b/mobile/android/base/tests/testPanCorrectness.java Wed Apr 30 19:51:24 2014 -0700
- @@ -11,7 +11,7 @@
- */
- public class testPanCorrectness extends PixelTest {
- public void testPanCorrectness() {
- - String url = getAbsoluteUrl("/robocop/robocop_boxes.html");
- + String url = getAbsoluteUrl(StringHelper.ROBOCOP_BOXES_URL);
- MotionEventHelper meh = new MotionEventHelper(getInstrumentation(), mDriver.getGeckoLeft(), mDriver.getGeckoTop());
- diff -r b227a707080f mobile/android/base/tests/testPermissions.java
- --- a/mobile/android/base/tests/testPermissions.java Wed Apr 30 13:15:46 2014 -0400
- +++ b/mobile/android/base/tests/testPermissions.java Wed Apr 30 19:51:24 2014 -0700
- @@ -18,7 +18,7 @@
- Actions.RepeatedEventExpecter paintExpecter;
- // Test geolocation notification
- - loadAndPaint(getAbsoluteUrl("/robocop/robocop_geolocation.html"));
- + loadAndPaint(getAbsoluteUrl(StringHelper.ROBOCOP_GEOLOCATION_URL));
- waitForText("wants your location");
- // Uncheck the "Don't ask again for this site" checkbox
- diff -r b227a707080f mobile/android/base/tests/testPictureLinkContextMenu.java
- --- a/mobile/android/base/tests/testPictureLinkContextMenu.java Wed Apr 30 13:15:46 2014 -0400
- +++ b/mobile/android/base/tests/testPictureLinkContextMenu.java Wed Apr 30 19:51:24 2014 -0700
- @@ -6,17 +6,17 @@
- // Test website strings
- private static String PICTURE_PAGE_URL;
- private static String BLANK_PAGE_URL;
- - private static final String PICTURE_PAGE_TITLE = "Picture Link";
- + private static final String PICTURE_PAGE_TITLE = StringHelper.ROBOCOP_PICTURE_LINK_TITLE;
- private static final String tabs [] = { "Image", "Link" };
- private static final String photoMenuItems [] = { "Copy Image Location", "Share Image", "Set Image As", "Save Image" };
- - private static final String linkMenuItems [] = { "Open Link in New Tab", "Open Link in Private Tab", "Copy Link", "Share Link", "Bookmark Link"};
- + private static final String linkMenuItems [] = StringHelper.CONTEXT_MENU_ITEMS_IN_NORMAL_TAB;
- private static final String imageTitle = "^Image$";
- public void testPictureLinkContextMenu() {
- blockForGeckoReady();
- - PICTURE_PAGE_URL=getAbsoluteUrl("/robocop/robocop_picture_link.html");
- - BLANK_PAGE_URL=getAbsoluteUrl("/robocop/robocop_blank_02.html");
- + PICTURE_PAGE_URL=getAbsoluteUrl(StringHelper.ROBOCOP_PICTURE_LINK_URL);
- + BLANK_PAGE_URL=getAbsoluteUrl(StringHelper.ROBOCOP_BLANK_PAGE_02_URL);
- loadAndPaint(PICTURE_PAGE_URL);
- verifyPageTitle(PICTURE_PAGE_TITLE);
- diff -r b227a707080f mobile/android/base/tests/testPromptGridInput.java
- --- a/mobile/android/base/tests/testPromptGridInput.java Wed Apr 30 13:15:46 2014 -0400
- +++ b/mobile/android/base/tests/testPromptGridInput.java Wed Apr 30 19:51:24 2014 -0700
- @@ -36,8 +36,8 @@
- public void test(final int num) {
- // Load about:blank between each test to ensure we reset state
- - loadUrl("about:blank");
- - mAsserter.ok(waitForText("about:blank"), "Loaded blank page", "page title match");
- + loadUrl(StringHelper.ABOUT_BLANK_URL);
- + mAsserter.ok(waitForText(StringHelper.ABOUT_BLANK_URL), "Loaded blank page", "page title match");
- loadUrl("chrome://roboextender/content/robocop_prompt_gridinput.html#test" + num);
- }
- diff -r b227a707080f mobile/android/base/tests/testReaderMode.java
- --- a/mobile/android/base/tests/testReaderMode.java Wed Apr 30 13:15:46 2014 -0400
- +++ b/mobile/android/base/tests/testReaderMode.java Wed Apr 30 19:51:24 2014 -0700
- @@ -72,7 +72,7 @@
- contentPageShowExpecter.unregisterListener();
- paintExpecter.blockUntilClear(EVENT_CLEAR_DELAY_MS);
- paintExpecter.unregisterListener();
- - verifyPageTitle("Robocop Text Page");
- + verifyPageTitle(StringHelper.ROBOCOP_TEXT_PAGE_TITLE);
- // Open the share menu for the reader toolbar
- height = mDriver.getGeckoTop() + mDriver.getGeckoHeight() - 10;
- @@ -103,7 +103,7 @@
- contentEventExpecter.unregisterListener();
- // Check if the page is present in the Reading List
- - mAsserter.ok(mSolo.waitForText("Robocop Text Page"), "Verify if the page is added to your Reading List", "The page is present in your Reading List");
- + mAsserter.ok(mSolo.waitForText(StringHelper.ROBOCOP_TEXT_PAGE_TITLE), "Verify if the page is added to your Reading List", "The page is present in your Reading List");
- // Check if the page is added in History tab like a Reading List item
- openAboutHomeTab(AboutHomeTabs.MOST_RECENT);
- @@ -113,7 +113,7 @@
- mSolo.clickLongOnView(child);
- mAsserter.ok(mSolo.waitForText("Open in Reader"), "Verify if the page is present in history as a Reading List item", "The page is present in history as a Reading List item");
- mActions.sendSpecialKey(Actions.SpecialKey.BACK); // Dismiss the context menu
- - mSolo.waitForText("Robocop Text Page");
- + mSolo.waitForText(StringHelper.ROBOCOP_TEXT_PAGE_TITLE);
- // Verify separately the Reading List entries for tablets and phone because for tablets there is an extra child in UI design
- if (devType.equals("phone")) {
- @@ -131,7 +131,7 @@
- mSolo.clickOnView(child);
- contentEventExpecter.blockForEvent();
- contentEventExpecter.unregisterListener();
- - verifyPageTitle("Robocop Text Page");
- + verifyPageTitle(StringHelper.ROBOCOP_TEXT_PAGE_TITLE);
- // Verify that we are in reader mode and remove the page from Reading List
- height = mDriver.getGeckoTop() + mDriver.getGeckoHeight() - 10;
- @@ -139,7 +139,7 @@
- mAsserter.dumpLog("Long Clicking at width = " + String.valueOf(width) + " and height = " + String.valueOf(height));
- mSolo.clickOnScreen(width,height);
- mAsserter.ok(mSolo.waitForText("Page removed from your Reading List"), "Waiting for the page to removed from your Reading List", "The page is removed from your Reading List");
- - verifyPageTitle("Robocop Text Page");
- + verifyPageTitle(StringHelper.ROBOCOP_TEXT_PAGE_TITLE);
- //Check if the Reading List is empty
- openAboutHomeTab(AboutHomeTabs.READING_LIST);
- diff -r b227a707080f mobile/android/base/tests/testSessionOOMRestore.java
- --- a/mobile/android/base/tests/testSessionOOMRestore.java Wed Apr 30 13:15:46 2014 -0400
- +++ b/mobile/android/base/tests/testSessionOOMRestore.java Wed Apr 30 19:51:24 2014 -0700
- @@ -17,7 +17,7 @@
- @Override
- public void setActivityIntent(Intent intent) {
- - PageInfo home = new PageInfo("about:home");
- + PageInfo home = new PageInfo(StringHelper.ABOUT_HOME_URL);
- PageInfo page1 = new PageInfo("page1");
- PageInfo page2 = new PageInfo("page2");
- PageInfo page3 = new PageInfo("page3");
- diff -r b227a707080f mobile/android/base/tests/testSessionOOMSave.java
- --- a/mobile/android/base/tests/testSessionOOMSave.java Wed Apr 30 13:15:46 2014 -0400
- +++ b/mobile/android/base/tests/testSessionOOMSave.java Wed Apr 30 19:51:24 2014 -0700
- @@ -17,7 +17,7 @@
- pageShowExpecter.blockForEvent();
- pageShowExpecter.unregisterListener();
- - PageInfo home = new PageInfo("about:home");
- + PageInfo home = new PageInfo(StringHelper.ABOUT_HOME_URL);
- PageInfo page1 = new PageInfo("page1");
- PageInfo page2 = new PageInfo("page2");
- PageInfo page3 = new PageInfo("page3");
- diff -r b227a707080f mobile/android/base/tests/testSettingsMenuItems.java
- --- a/mobile/android/base/tests/testSettingsMenuItems.java Wed Apr 30 13:15:46 2014 -0400
- +++ b/mobile/android/base/tests/testSettingsMenuItems.java Wed Apr 30 19:51:24 2014 -0700
- @@ -14,8 +14,6 @@
- * default values for them
- */
- public class testSettingsMenuItems extends PixelTest {
- - String BRAND_NAME = "(Fennec|Nightly|Aurora|Firefox|Firefox Beta)";
- -
- /**
- * The following String[][] (arrays) match the menu hierarchy for each section.
- * Each String[] (array) represents the menu items/choices in the following order:
- @@ -29,51 +27,51 @@
- */
- // Customize menu items.
- - String[] PATH_CUSTOMIZE = { "Customize" };
- + String[] PATH_CUSTOMIZE = { StringHelper.CUSTOMIZE_SECTION_LABEL };
- String[][] OPTIONS_CUSTOMIZE = {
- { "Home" },
- { "Search", "", "Show search suggestions", "Installed search engines"},
- - { "Tabs", "Don't restore after quitting " + BRAND_NAME, "Always restore", "Don't restore after quitting " + BRAND_NAME },
- - { "Import from Android", "", "Bookmarks", "History", "Import" },
- + { StringHelper.TABS_LABEL, "Don't restore after quitting " + StringHelper.BRAND_NAME, "Always restore", "Don't restore after quitting " + StringHelper.BRAND_NAME },
- + { StringHelper.IMPORT_FROM_ANDROID_LABEL, "", "Bookmarks", "History", "Import" },
- };
- // Home panel menu items.
- - String[] PATH_HOME = { "Customize", "Home" };
- + String[] PATH_HOME = { StringHelper.CUSTOMIZE_SECTION_LABEL, "Home" };
- String[][] OPTIONS_HOME = {
- { "Panels" },
- { "Automatic updates", "Enabled", "Enabled", "Only over Wi-Fi" },
- };
- // Display menu items.
- - String[] PATH_DISPLAY = { "Display" };
- + String[] PATH_DISPLAY = { StringHelper.DISPLAY_SECTION_LABEL };
- String[][] OPTIONS_DISPLAY = {
- - { "Text size" },
- - { "Title bar", "Show page title", "Show page title", "Show page address" },
- + { StringHelper.TEXT_SIZE_LABEL },
- + { StringHelper.TITLE_BAR_LABEL, StringHelper.SHOW_PAGE_TITLE_LABEL, StringHelper.SHOW_PAGE_TITLE_LABEL, StringHelper.SHOW_PAGE_ADDRESS_LABEL },
- { "Advanced" },
- - { "Character encoding", "Don't show menu", "Show menu", "Don't show menu" },
- - { "Plugins", "Tap to play", "Enabled", "Tap to play", "Disabled" },
- + { StringHelper.CHARACTER_ENCODING_LABEL, "Don't show menu", "Show menu", "Don't show menu" },
- + { StringHelper.PLUGINS_LABEL, "Tap to play", "Enabled", "Tap to play", "Disabled" },
- };
- // Privacy menu items.
- String[] PATH_PRIVACY = { "Privacy" };
- String[][] OPTIONS_PRIVACY = {
- - { "Tracking", "Do not tell sites anything about my tracking preferences", "Tell sites that I do not want to be tracked", "Tell sites that I want to be tracked", "Do not tell sites anything about my tracking preferences" },
- - { "Cookies", "Enabled", "Enabled, excluding 3rd party", "Disabled" },
- - { "Remember passwords" },
- - { "Use master password" },
- - { "Clear private data", "", "Browsing history", "Downloads", "Form & search history", "Cookies & active logins", "Saved passwords", "Cache", "Offline website data", "Site settings", "Clear data" },
- + { StringHelper.TRACKING_LABEL, "Do not tell sites anything about my tracking preferences", "Tell sites that I do not want to be tracked", "Tell sites that I want to be tracked", "Do not tell sites anything about my tracking preferences" },
- + { StringHelper.COOKIES_LABEL, "Enabled", "Enabled, excluding 3rd party", "Disabled" },
- + { StringHelper.REMEMBER_PASSWORDS_LABEL },
- + { StringHelper.MASTER_PASSWORD_LABEL },
- + { StringHelper.CLEAR_PRIVATE_DATA_LABEL, "", "Browsing history", "Downloads", "Form & search history", "Cookies & active logins", "Saved passwords", "Cache", "Offline website data", "Site settings", "Clear data" },
- };
- // Mozilla/vendor menu items.
- String[] PATH_MOZILLA = { "Mozilla" };
- String[][] OPTIONS_MOZILLA = {
- - { "About " + BRAND_NAME },
- - { "FAQs" },
- - { "Give feedback" },
- - { "Show product announcements" },
- + { StringHelper.ABOUT_LABEL },
- + { StringHelper.FAQS_LABEL },
- + { StringHelper.FEEDBACK_LABEL },
- + { StringHelper.PRODUCT_ANNOUNCEMENTS_LABEL },
- { "Data choices" },
- - { BRAND_NAME + " Health Report", "Shares data with Mozilla about your browser health and helps you understand your browser performance" },
- - { "View my Health Report" },
- + { StringHelper.HEALTH_REPORT_LABEL, "Shares data with Mozilla about your browser health and helps you understand your browser performance" },
- + { StringHelper.MY_HEALTH_REPORT_LABEL },
- };
- /*
- @@ -105,18 +103,18 @@
- // Set special handling for Settings items that are conditionally built.
- addConditionalSettings(settingsMenuItems);
- - selectMenuItem("Settings");
- - waitForText("Settings");
- + selectMenuItem(StringHelper.SETTINGS_LABEL);
- + waitForText(StringHelper.SETTINGS_LABEL);
- // Dismiss the Settings screen and verify that the view is returned to about:home page
- mActions.sendSpecialKey(Actions.SpecialKey.BACK);
- // Waiting for page title to appear to be sure that is fully loaded before opening the menu
- waitForText("Enter Search");
- - verifyUrl("about:home");
- + verifyUrl(StringHelper.ABOUT_HOME_URL);
- - selectMenuItem("Settings");
- - waitForText("Settings");
- + selectMenuItem(StringHelper.SETTINGS_LABEL);
- + waitForText(StringHelper.SETTINGS_LABEL);
- checkForSync(mDevice);
- @@ -136,7 +134,7 @@
- waitForEnabledText(customizeString);
- mSolo.clickOnText(customizeString);
- }
- - mAsserter.ok(mSolo.waitForText("Sync"), "Waiting for Sync option", "The Sync option is present");
- + mAsserter.ok(mSolo.waitForText(StringHelper.SYNC_LABEL), "Waiting for Sync option", "The Sync option is present");
- }
- /**
- @@ -166,13 +164,13 @@
- // Crash reporter
- if (AppConstants.MOZ_CRASHREPORTER) {
- - String[] crashReporterUi = { "Crash Reporter", BRAND_NAME + " submits crash reports to help Mozilla make your browser more stable and secure" };
- + String[] crashReporterUi = { "Crash Reporter", StringHelper.BRAND_NAME + " submits crash reports to help Mozilla make your browser more stable and secure" };
- settingsMap.get(PATH_MOZILLA).add(crashReporterUi);
- }
- // Telemetry
- if (AppConstants.MOZ_TELEMETRY_REPORTING) {
- - String[] telemetryUi = { "Telemetry", "Shares performance, usage, hardware and customization data about your browser with Mozilla to help us make " + BRAND_NAME + " better" };
- + String[] telemetryUi = { "Telemetry", "Shares performance, usage, hardware and customization data about your browser with Mozilla to help us make " + StringHelper.BRAND_NAME + " better" };
- settingsMap.get(PATH_MOZILLA).add(telemetryUi);
- }
- }
- diff -r b227a707080f mobile/android/base/tests/testShareLink.java
- --- a/mobile/android/base/tests/testShareLink.java Wed Apr 30 13:15:46 2014 -0400
- +++ b/mobile/android/base/tests/testShareLink.java Wed Apr 30 19:51:24 2014 -0700
- @@ -25,10 +25,10 @@
- */
- public class testShareLink extends AboutHomeTest {
- String url;
- - String urlTitle = "Big Link";
- + String urlTitle = StringHelper.ROBOCOP_BIG_LINK_TITLE;
- public void testShareLink() {
- - url = getAbsoluteUrl("/robocop/robocop_big_link.html");
- + url = getAbsoluteUrl(StringHelper.ROBOCOP_BIG_LINK_URL);
- ArrayList<String> shareOptions;
- blockForGeckoReady();
- @@ -38,7 +38,7 @@
- inputAndLoadUrl(url);
- verifyPageTitle(urlTitle); // Waiting for page title to ensure the page is loaded
- - selectMenuItem("Share");
- + selectMenuItem(StringHelper.SHARE_LABEL);
- if (Build.VERSION.SDK_INT >= 14) {
- // Check for our own sync in the submenu.
- waitForText("Sync$");
- @@ -93,16 +93,16 @@
- // Prepopulate top sites with history items to overflow tiles.
- // We are trying to move away from using reflection and doing more black-box testing.
- - inputAndLoadUrl(getAbsoluteUrl("/robocop/robocop_blank_01.html"));
- - inputAndLoadUrl(getAbsoluteUrl("/robocop/robocop_blank_02.html"));
- - inputAndLoadUrl(getAbsoluteUrl("/robocop/robocop_blank_03.html"));
- - inputAndLoadUrl(getAbsoluteUrl("/robocop/robocop_blank_04.html"));
- + inputAndLoadUrl(getAbsoluteUrl(StringHelper.ROBOCOP_BLANK_PAGE_01_URL));
- + inputAndLoadUrl(getAbsoluteUrl(StringHelper.ROBOCOP_BLANK_PAGE_02_URL));
- + inputAndLoadUrl(getAbsoluteUrl(StringHelper.ROBOCOP_BLANK_PAGE_03_URL));
- + inputAndLoadUrl(getAbsoluteUrl(StringHelper.ROBOCOP_BLANK_PAGE_04_URL));
- if (mDevice.type.equals("tablet")) {
- // Tablets have more tile spaces to fill.
- - inputAndLoadUrl(getAbsoluteUrl("/robocop/robocop_blank_05.html"));
- - inputAndLoadUrl(getAbsoluteUrl("/robocop/robocop_boxes.html"));
- - inputAndLoadUrl(getAbsoluteUrl("/robocop/robocop_search.html"));
- - inputAndLoadUrl(getAbsoluteUrl("/robocop/robocop_text_page.html"));
- + inputAndLoadUrl(getAbsoluteUrl(StringHelper.ROBOCOP_BLANK_PAGE_05_URL));
- + inputAndLoadUrl(getAbsoluteUrl(StringHelper.ROBOCOP_BOXES_URL));
- + inputAndLoadUrl(getAbsoluteUrl(StringHelper.ROBOCOP_SEARCH_URL));
- + inputAndLoadUrl(getAbsoluteUrl(StringHelper.ROBOCOP_TEXT_PAGE_URL));
- }
- // Test the share popup in Top Sites.
- diff -r b227a707080f mobile/android/base/tests/testSystemPages.java
- --- a/mobile/android/base/tests/testSystemPages.java Wed Apr 30 13:15:46 2014 -0400
- +++ b/mobile/android/base/tests/testSystemPages.java Wed Apr 30 19:51:24 2014 -0700
- @@ -12,21 +12,21 @@
- public void testSystemPages() {
- blockForGeckoReady();
- - String urls [] = { "about:firefox", "about:rights", "about:addons", "about:downloads", "about:buildconfig", "about:feedback", "about:healthreport", "about:" };
- + String urls [] = { StringHelper.ABOUT_FIREFOX_URL, StringHelper.ABOUT_RIGHTS_URL, StringHelper.ABOUT_ADDONS_URL, StringHelper.ABOUT_DOWNLOADS_URL, StringHelper.ABOUT_BUILDCONFIG_URL, StringHelper.ABOUT_FEEDBACK_URL, StringHelper.ABOUT_HEALTHREPORT_URL, StringHelper.ABOUT_URL };
- // Pages to be tested from the menu and their expected urls. This if of the form { {{ <path to item> }, { <expected url> }}* }
- - String menuItems [][][] = {{{ "Apps" }, { "about:apps" }},
- - {{ "Downloads" }, { "about:downloads" }},
- - {{ "Add-ons" }, { "about:addons" }},
- - {{ "Settings", "Mozilla", "About (Fennec|Nightly|Aurora|Firefox|Firefox Beta)" }, { "about:" }},
- - {{ "Settings", "Mozilla", "Give feedback" }, { "about:feedback" }},
- - {{ "Settings", "Mozilla", "View my Health Report" }, { "about:healthreport" }}};
- + String menuItems [][][] = {{{ StringHelper.APPS_LABEL }, { StringHelper.ABOUT_APPS_URL }},
- + {{ StringHelper.DOWNLOADS_LABEL }, { StringHelper.ABOUT_DOWNLOADS_URL}},
- + {{ StringHelper.ADDONS_LABEL }, { StringHelper.ABOUT_ADDONS_URL }},
- + {{ StringHelper.SETTINGS_LABEL, StringHelper.MOZILLA_SECTION_LABEL, StringHelper.ABOUT_LABEL }, { StringHelper.ABOUT_URL }},
- + {{ StringHelper.SETTINGS_LABEL, StringHelper.MOZILLA_SECTION_LABEL, StringHelper.FEEDBACK_LABEL }, { StringHelper.ABOUT_FEEDBACK_URL }},
- + {{ StringHelper.SETTINGS_LABEL, StringHelper.MOZILLA_SECTION_LABEL, StringHelper.MY_HEALTH_REPORT_LABEL }, { StringHelper.ABOUT_HEALTHREPORT_URL }}};
- /* Load system pages from url and check that the pages are loaded in the same tab */
- checkUrl(urls);
- /* Verify that the search field is not in the focus by pressing back. That will load the previous
- about: page if there is no the keyboard to dismiss, meaning that the search field was not in focus */
- - loadAndPaint("about:about");
- + loadAndPaint(StringHelper.ABOUT_ABOUT_URL);
- // Press back to verify if the keyboard is dismissed or the previous about: page loads
- mActions.sendSpecialKey(Actions.SpecialKey.BACK);
- @@ -34,8 +34,8 @@
- mSolo.sleep(AFTER_BACK_SLEEP_MS);
- // We will use the "about:" page as our reference page.
- - loadAndPaint("about:");
- - verifyUrl("about:"); // Verify that the previous about: page is loaded, meaning no keyboard was present
- + loadAndPaint(StringHelper.ABOUT_URL);
- + verifyUrl(StringHelper.ABOUT_URL); // Verify that the previous about: page is loaded, meaning no keyboard was present
- // Load system pages by navigating through the UI.
- loadItemsByLevel(menuItems);
- @@ -68,7 +68,7 @@
- selectMenuItemByPath(pathToItem);
- // Wait for the new tab and page to load
- - if ("about:".equals(expectedUrl)) {
- + if (StringHelper.ABOUT_URL.equals(expectedUrl)) {
- waitForPaint(paintExpecter); // Waiting for the page to load
- paintExpecter.unregisterListener();
- } else {
- @@ -79,7 +79,7 @@
- contentEventExpecter.unregisterListener();
- verifyUrl(expectedUrl);
- - if ("about:".equals(expectedUrl)) {
- + if (StringHelper.ABOUT_URL.equals(expectedUrl)) {
- // Decreasing because we do not expect this to be in a different tab.
- expectedTabCount--;
- }
- diff -r b227a707080f mobile/android/base/tests/testThumbnails.java
- --- a/mobile/android/base/tests/testThumbnails.java Wed Apr 30 13:15:46 2014 -0400
- +++ b/mobile/android/base/tests/testThumbnails.java Wed Apr 30 19:51:24 2014 -0700
- @@ -32,7 +32,7 @@
- mSolo.sleep(thumbnailDelay);
- inputAndLoadUrl(site2Url);
- mSolo.sleep(thumbnailDelay);
- - inputAndLoadUrl("about:home");
- + inputAndLoadUrl(StringHelper.ABOUT_HOME_URL);
- waitForTest(new ThumbnailTest(site1Title, Color.GREEN), 5000);
- mAsserter.is(getTopSiteThumbnailColor(site1Title), Color.GREEN, "Top site thumbnail updated for HTTP 200");
- waitForTest(new ThumbnailTest(site2Title, Color.GREEN), 5000);
- @@ -43,7 +43,7 @@
- mSolo.sleep(thumbnailDelay);
- inputAndLoadUrl(site2Url);
- mSolo.sleep(thumbnailDelay);
- - inputAndLoadUrl("about:home");
- + inputAndLoadUrl(StringHelper.ABOUT_HOME_URL);
- waitForTest(new ThumbnailTest(site1Title, Color.RED), 5000);
- mAsserter.is(getTopSiteThumbnailColor(site1Title), Color.RED, "Top site thumbnail updated for HTTP 200");
- waitForTest(new ThumbnailTest(site2Title, Color.GREEN), 5000);
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement