Untitled
By: a guest | Apr 16th, 2009 | Syntax:
C | Size: 1.37 KB | Hits: 40 | Expires: Never
/* Problem: Inefficient and confusing */
int foo(int bar)
{
int return_value = 0;
int doing_okay = 1;
doing_okay = do_something( bar );
if (doing_okay)
{
doing_okay = init_stuff();
}
if (doing_okay)
{
doing_okay = prepare_stuff();
}
if (doing_okay)
{
return_value = do_the_thing( bar );
}
return return_value;
}
/* Problem: Getting murdered by PHB's for using goto */
int foo(int bar)
{
if (!do_something( bar )) {
goto error;
}
if (!init_stuff( bar )) {
goto error;
}
if (!prepare_stuff( bar )) {
goto error;
}
return do_the_thing( bar );
error:
return 0;
}
/* Problem: Too many nested blocks, horrible */
int foo(int bar)
{
int return_value = 0;
if (do_something( bar )) {
if (init_stuff( bar )) {
if (prepare_stuff( bar )) {
return_value = do_the_thing( bar );
}
}
}
return return_value;
}
/* Problem: Too awesome */
int foo(int bar)
{
return
do_something(bar) &&
init_stuff(bar) &&
prepare_stuff(bar) &&
do_the_thing(bar);
}