Untitled

1) Indentation is a mess

 

2) First param to MasterTemplate::setup is the page title so it should reflect what the page does.

 

3) Use of prefixes (especially in post and get results) is discouraged. Use 'mode' instead of 'mode'

 

4) commenting whilst helpful is only helpful when correct ;)

 

5) If you only have a single post value being sent use a descriptive name ('reveal' is more descriptive than 'mode' for instance)

 

6) Try to avoid assigning variables if you're only going to use them once

 

7) Using $class->name with Entity Classes (character, city, ship, etc) isn't required as $class has a valid toString() method that is called by default if you just use echo $class;

 

8) When using flash, you should either show the pages content again so that they can fix any mistakes they've made or redirect them to a valid page. (The flash will persist if MasterTemplate::redirect is used)

 

9) If your method is set to POST don't use GET variables. (reveal.php?strMode=reveal)

 

10) Try to keep your HTML HTML 5 compliant