Advertisement
PVS-StudioWarnings

PVS-Studio warning V501 for Geant4

Nov 27th, 2014
173
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.94 KB | None | 0 0
  1. G4double G4Cons::DistanceToOut( const G4ThreeVector& p,
  2.                                 const G4ThreeVector& v,
  3.                                 const G4bool calcNorm,
  4.                                       G4bool *validNorm,
  5.                                       G4ThreeVector *n) const
  6. {
  7.   ....
  8.   if( p.x() != 0. || p.x() != 0.)
  9.   {
  10.     G4cout << "point phi = " << std::atan2(p.y(),p.x())/degree
  11.            << " degree" << G4endl << G4endl ;
  12.   }
  13.   ....
  14. }
  15.  
  16. Most likely this is what should be written here: p.x() != 0. || p.y() != 0.
  17.  
  18. This suspicious code was found in Geant4 project by PVS-Studio static code analyzer.
  19. Warning message is:
  20. V501 There are identical sub-expressions to the left and to the right of the '||' operator: p.x() != 0. || p.x() != 0. G4csg g4cons.cc 2041
  21.  
  22. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement